Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update opentelemetry-bootstrap to install dependencies for both aiohttp-server and aiohttp-client #2059

Closed
wants to merge 5 commits into from
Closed

Conversation

hartungstenio
Copy link
Contributor

@hartungstenio hartungstenio commented Nov 13, 2023

Description

Since the addition of aiohttp-server instrumentation, there are multiple projects instrumenting the aiohttp library.

bootstrap_gen uses a dict with the instrumented library (aiohttp) as key, and had two equal keys, leaving only the second one (aiohttp-server) in the final dict. Running opentelemetry-bootstrap -a requirements in a project using aiohttp can confirm this.

This changes that file to store the libraries as a list to fix that problem. After this, both aiohttp-client and aiohttp-server are listed as requirements.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Nov 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@hartungstenio hartungstenio marked this pull request as ready for review November 13, 2023 22:03
@hartungstenio hartungstenio requested a review from a team November 13, 2023 22:03
@hartungstenio hartungstenio changed the title change bootstrap_gen to use a list instead of dict instrument both aiohttp-client and aiohttp-server using opentelemetry-instrument Nov 14, 2023
@hartungstenio hartungstenio changed the title instrument both aiohttp-client and aiohttp-server using opentelemetry-instrument update opentelemetry-bootstrap to install dependencies for both aiohttp-server and aiohttp-client Nov 14, 2023
@srikanthccv
Copy link
Member

Please sign the CLA

@hartungstenio hartungstenio marked this pull request as draft December 6, 2023 20:14
@hartungstenio
Copy link
Contributor Author

Closing since this got merged in another pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants