Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable global propagator for AWS instrumentation #2599

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jun 11, 2024

Fixes #2598

@ocelotl ocelotl self-assigned this Jun 11, 2024
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they just need to be deleted.

@ocelotl ocelotl force-pushed the issue_2598 branch 2 times, most recently from 4d017d0 to 8395c48 Compare June 13, 2024 23:54
@ocelotl ocelotl force-pushed the issue_2598 branch 2 times, most recently from 5cfe891 to 2187270 Compare July 19, 2024 00:09
@ocelotl ocelotl requested a review from tylerbenson July 19, 2024 22:04
@ocelotl ocelotl marked this pull request as ready for review July 19, 2024 22:16
@ocelotl ocelotl requested a review from a team July 19, 2024 22:16
@ocelotl ocelotl changed the title WIP Enable global propagator for AWS instrumentation Jul 19, 2024
@xrmx
Copy link
Contributor

xrmx commented Jul 22, 2024

Why this change? There's not a single text line in the issue, commit or PR 😅

Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @rapphil in case you want to take a look too.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 22, 2024

Why this change? There's not a single text line in the issue, commit or PR 😅

Sorry, I updated the issue with a description ✌️

@ocelotl ocelotl force-pushed the issue_2598 branch 2 times, most recently from abda71b to d43bfd9 Compare July 23, 2024 18:25
CHANGELOG.md Show resolved Hide resolved
@ocelotl ocelotl enabled auto-merge (squash) July 24, 2024 00:00
@ocelotl ocelotl disabled auto-merge July 24, 2024 00:03
ocelotl and others added 3 commits July 24, 2024 10:30
…ject.toml

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…/test_aws_lambda_instrumentation_manual.py

Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
@ocelotl ocelotl closed this Jul 24, 2024
@ocelotl ocelotl reopened this Jul 24, 2024
@ocelotl ocelotl merged commit a47810c into open-telemetry:main Jul 24, 2024
383 checks passed
@ocelotl ocelotl deleted the issue_2598 branch July 24, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable global propagator for AWS instrumentation
6 participants