Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ids_generator references from moving from api to sdk #283

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jan 8, 2021

@lzchen lzchen requested review from a team, toumorokoshi and hectorhdzg and removed request for a team January 8, 2021 19:13
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking comment worth taking a look, but LGTM!

@@ -18,6 +18,7 @@
from opentelemetry import trace as trace_api
from opentelemetry.exporter.datadog import constants, propagator
from opentelemetry.sdk import trace
from opentelemetry.sdk.trace.ids_generator import RandomIdsGenerator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be promoting direct imports from these sub-modules, or just ensuring that all required classes can be imported from the top-level-ish opentelemetry.sdk.trace module?

I feel like it's a bit rigid to import things from opentelemetry.sdk.trace.ids_generator (can't refactor the codebase if you have to split classes / etc).

If you make opentelemetry.sdk.trace a kitchen sink with all of these classes, you not only enable that ability to refactor, but you also reduce the friction on the user having to remember what module some class actually is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you but possibly could be addressed in a later date.

@lzchen lzchen merged commit d12f67f into open-telemetry:master Jan 11, 2021
@lzchen lzchen deleted the id branch January 11, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants