Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consistent import statement for URLLibInstrumentor #2868

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Add consistent import statement for URLLibInstrumentor #2868

merged 3 commits into from
Sep 13, 2024

Conversation

BryanFauble
Copy link
Contributor

Description

  1. Adds the import statement to the top of the python script for consistent as show in other examples like: https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-httpx#instrumenting-all-clients
  2. Updates the example script to fix an extra ) that was included

Type of change

Please delete options that are not relevant.

  • Documentation update

How Has This Been Tested?

This change was found and tested as a part of a repo I am maintaining: https://github.com/Sage-Bionetworks/synapsePythonClient

Does This PR Require a Core Repo Change?

  • [X ] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Changelogs have been updated (Not required per Contributing docs as behavior did not change)

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 12, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 12, 2024
@xrmx xrmx merged commit bed13f5 into open-telemetry:main Sep 13, 2024
521 checks passed
@BryanFauble BryanFauble deleted the patch-1 branch September 13, 2024 15:09
lmolkova pushed a commit to lmolkova/opentelemetry-python-contrib that referenced this pull request Sep 14, 2024
@BryanFauble @lmolkova
Add consistent import statement for URLLibInstrumentor (open-telemetr…
c43972a 
…y#2868)

* Add consistent import statement for URLLibInstrumentor

* Correct code in example

* One last correction to doc to create instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@emdneto emdneto emdneto approved these changes

@shalevr shalevr Awaiting requested review from shalevr

Assignees

@shalevr shalevr

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BryanFauble @xrmx @emdneto @shalevr