Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case insensitive header key retrieval for asgi instrumentation #308

Merged
merged 5 commits into from
Feb 5, 2021

Conversation

garnertan
Copy link
Contributor

Description

Made Asgi Instrumentor retrieve header keys in lower case.

Fixes #307

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tox -e test-instrumentation-asgi

Added new test cases in test_getter.py

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@garnertan garnertan requested review from a team, codeboten and toumorokoshi and removed request for a team January 31, 2021 11:55
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 31, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Good catch.

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a quick update to the changelog as per @toumorokoshi's comment. Also please sign the CLA

@garnertan
Copy link
Contributor Author

Thanks for reviewing. I added the pull request in the changelog.

@codeboten codeboten merged commit 55efeb6 into open-telemetry:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asgi request headers are not retrieved properly
3 participants