Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better file naming for AWS XRay Propagator + Add NathanielRN Propagator CODEOWNER #729

Merged

Conversation

NathanielRN
Copy link
Contributor

Description

Follow up to #720

We put the propagator code in aws_xray_format.py instead of __init__.py to make it easier to find in the repo. By putting it as an export in the __init__.py file you can still import it at the same location.

Also add myself @NathanielRN as a codeowner for the propagator so I get notified when there is a request to change it.

Description

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test make sure the import still works.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
    - [ ] Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

@NathanielRN NathanielRN requested a review from a team October 12, 2021 16:32
@NathanielRN NathanielRN added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 12, 2021
@NathanielRN NathanielRN force-pushed the move-aws-propagator-into-its-own-file branch 2 times, most recently from 10d79f5 to 7b8a526 Compare October 12, 2021 17:23
@owais owais enabled auto-merge (squash) October 12, 2021 17:26
@NathanielRN NathanielRN force-pushed the move-aws-propagator-into-its-own-file branch 2 times, most recently from 9bd08d4 to fcc9351 Compare October 12, 2021 18:57
@NathanielRN NathanielRN removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 12, 2021
@NathanielRN NathanielRN force-pushed the move-aws-propagator-into-its-own-file branch from fcc9351 to ae20787 Compare October 12, 2021 18:58
@owais owais merged commit 78f887e into open-telemetry:main Oct 12, 2021
@NathanielRN NathanielRN deleted the move-aws-propagator-into-its-own-file branch October 12, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants