Add instrumentation for AWS Lambda Service - pkg metadata files (Part 1/2) #739

NathanielRN · 2021-10-14T04:32:31Z

Description

In this PR, we ONLY add package metadata files.

This PR adds Instrumentation for Lambda functions on the AWS Lambda service. Specifically, when you use AWS Lambda to call your def lambda_handler(lambda_event, lambda_context) on AWS, you can use this instrumentation package and its scripts to instrument that invocation with OpenTelemetry!

OpenTelemetry already hosts this code on the OpenTelemetry Lambda repository, but it has a TODO to migrate it here, to the OpenTelemetry Python Contrib repository.

Instrumenting AWS Lambda is defined in the OpenTelemetry specifications and "AWS Lambda Instrumentations" also already exist in other languages:

You can learn more about how they are used on the AWS Distro for OpenTelemetry - Python Lambda Layer documentation

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

N/A

Does This PR Require a Core Repo Change?

Yes. Link to PR: Add AWS Lambda Instrumentation to boostrap_gen.py opentelemetry-python#2197

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

Followed the style guidelines of this project
Changelogs have been updated
Unit tests have been added
Documentation has been updated

...elemetry-instrumentation-aws_lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py

instrumentation/opentelemetry-instrumentation-aws_lambda/scripts/otel-instrument

owais

Q: How would this work if the lambda uses a framework like flask or falcon? Wouldn't that result in two SERVER spans?

instrumentation/opentelemetry-instrumentation-aws_lambda/setup.cfg

...elemetry-instrumentation-aws_lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py

owais

aiohttp-client uses - as the separate but this PR is using _ i.e, aws_lambda instead of aws-lambda. Can we use aws-lambda instead?

owais · 2021-10-25T15:39:10Z

...elemetry-instrumentation-aws_lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py

+        with tracer.start_as_current_span(
+            name=orig_handler_name,
+            context=parent_context,
+            kind=SpanKind.SERVER,


What if the lambda was triggered by SQS/SNS/Kinesis/S3/etc? It would be a consumer span in that case.

Moved this conversation to #777 (comment)

...telemetry-instrumentation-aws_lambda/src/opentelemetry/instrumentation/aws_lambda/package.py

instrumentation/opentelemetry-instrumentation-aws_lambda/README.rst

instrumentation/opentelemetry-instrumentation-aws_lambda/setup.cfg

NathanielRN · 2021-10-25T22:25:09Z

@owais @lzchen Thank you for your comments! 🙂 I'm moving most of the Python code into #777 to make this PR easy to review. Will address your further questions there!

instrumentation/opentelemetry-instrumentation-aws-lambda/setup.cfg

opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py

owais · 2021-10-25T22:33:25Z

Sorry for the trouble but any chance we can convert this into PR number 2 with all the code and create a new PR with the package skeleton? 😬

Only asking because we already started a review on this and it'd be weird to have these discussions in the wrong place. Happy to copy all the comments and add them to another PR though if it is too much trouble.

NathanielRN · 2021-10-25T22:39:08Z

@owais

Only asking because we already started a review on this and it'd be weird to have these discussions in the wrong place. Happy to copy all the comments and add them to another PR though if it is too much trouble.

Oh I was going to copy all your Python code related comments to #777! It's pretty dependent on this PR so I thought it would be best to merge this one first 🙂 If you prefer to make this PR the "Python code" PR we can do that instead though? Let me know!

owais · 2021-10-25T22:45:16Z

Whatever is easier for you @NathanielRN

… 1/2) (open-telemetry#739) * Add instrumentation for AWS Lambda Service * Add AWS Lambda package metadata files

NathanielRN requested a review from a team October 14, 2021 04:32

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch 3 times, most recently from b2b0422 to fc943f4 Compare October 14, 2021 05:06

NathanielRN mentioned this pull request Oct 14, 2021

Add AWS Lambda Instrumentation to boostrap_gen.py open-telemetry/opentelemetry-python#2197

Merged

3 tasks

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch from fc943f4 to 0f15526 Compare October 14, 2021 05:11

NathanielRN mentioned this pull request Oct 14, 2021

Move python lambda instrumentation and resource detector to opentelemetry-python-contrib open-telemetry/opentelemetry-lambda#85

Closed

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch 2 times, most recently from ecebc7a to 6f99ec4 Compare October 14, 2021 05:24

NathanielRN commented Oct 14, 2021

View reviewed changes

...elemetry-instrumentation-aws_lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py Outdated Show resolved Hide resolved

NathanielRN marked this pull request as draft October 14, 2021 06:32

NathanielRN mentioned this pull request Oct 21, 2021

Using upstream OTel auto instrumentation and minimize otel_wrapper open-telemetry/opentelemetry-lambda#158

Closed

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch 4 times, most recently from 301d2bc to 3fc7fff Compare October 22, 2021 17:32

NathanielRN marked this pull request as ready for review October 22, 2021 17:33

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch from 3fc7fff to 7cb3428 Compare October 22, 2021 17:36

NathanielRN commented Oct 22, 2021

View reviewed changes

...elemetry-instrumentation-aws_lambda/src/opentelemetry/instrumentation/aws_lambda/__init__.py Outdated Show resolved Hide resolved

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch 4 times, most recently from a710b10 to 7c0787b Compare October 22, 2021 19:05

NathanielRN commented Oct 25, 2021

View reviewed changes

instrumentation/opentelemetry-instrumentation-aws_lambda/scripts/otel-instrument Outdated Show resolved Hide resolved

owais reviewed Oct 25, 2021

View reviewed changes

lzchen reviewed Oct 25, 2021

View reviewed changes

instrumentation/opentelemetry-instrumentation-aws_lambda/README.rst Outdated Show resolved Hide resolved

lzchen reviewed Oct 25, 2021

View reviewed changes

instrumentation/opentelemetry-instrumentation-aws_lambda/setup.cfg Outdated Show resolved Hide resolved

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch from 7c0787b to 2a20f4d Compare October 25, 2021 19:32

NathanielRN changed the title ~~Add instrumentation for AWS Lambda Service~~ Add instrumentation for AWS Lambda Service - pkg metadata files (Part 1/2) Oct 25, 2021

NathanielRN mentioned this pull request Oct 25, 2021

Add instrumentation for AWS Lambda Service - Implementation (Part 2/2) #777

Merged

6 tasks

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch 4 times, most recently from 05a8c46 to 1d984e8 Compare October 25, 2021 22:15

NathanielRN requested review from owais and lzchen October 25, 2021 22:24

owais approved these changes Oct 25, 2021

View reviewed changes

instrumentation/opentelemetry-instrumentation-aws-lambda/setup.cfg Show resolved Hide resolved

opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py Show resolved Hide resolved

NathanielRN mentioned this pull request Oct 25, 2021

Give instrumentations of stdlib packages a separate symbol so know when to use instrumentation pkg #779

Open

NathanielRN added 2 commits October 26, 2021 10:14

Add instrumentation for AWS Lambda Service

4174a55

Add AWS Lambda package metadata files

657c2b1

NathanielRN force-pushed the add-aws_lambda-instrumentation-package branch from 1d984e8 to 657c2b1 Compare October 26, 2021 14:14

owais approved these changes Oct 26, 2021

View reviewed changes

owais merged commit dbc6a86 into open-telemetry:main Oct 26, 2021

NathanielRN deleted the add-aws_lambda-instrumentation-package branch October 26, 2021 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add instrumentation for AWS Lambda Service - pkg metadata files (Part 1/2) #739

Add instrumentation for AWS Lambda Service - pkg metadata files (Part 1/2) #739

NathanielRN commented Oct 14, 2021 •

edited

Loading

owais left a comment

owais left a comment

owais Oct 25, 2021

NathanielRN Oct 26, 2021

NathanielRN commented Oct 25, 2021

owais commented Oct 25, 2021

NathanielRN commented Oct 25, 2021

owais commented Oct 25, 2021

Add instrumentation for AWS Lambda Service - pkg metadata files (Part 1/2) #739

Add instrumentation for AWS Lambda Service - pkg metadata files (Part 1/2) #739

Conversation

NathanielRN commented Oct 14, 2021 • edited Loading

Description

Type of change

How Has This Been Tested?

Does This PR Require a Core Repo Change?

Checklist:

owais left a comment

Choose a reason for hiding this comment

owais left a comment

Choose a reason for hiding this comment

owais Oct 25, 2021

Choose a reason for hiding this comment

NathanielRN Oct 26, 2021

Choose a reason for hiding this comment

NathanielRN commented Oct 25, 2021

owais commented Oct 25, 2021

NathanielRN commented Oct 25, 2021

owais commented Oct 25, 2021

NathanielRN commented Oct 14, 2021 •

edited

Loading