Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trailing_metadata to _OpenTelemetryServicerContext #871

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

jbraswell
Copy link
Contributor

@jbraswell jbraswell commented Jan 20, 2022

Description

The trailing_metadata method was added to grpc._server.ServicerContext in gRPC v1.38.0.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually validated this change works with our custom gRPC interceptors.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jbraswell jbraswell requested a review from a team January 20, 2022 18:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2022

CLA Signed

The committers are authorized under a signed CLA.

The trailing_metadata method was added to grpc._server.ServicerContext
in gRPC v1.38.0.
@owais owais merged commit a2098c3 into open-telemetry:main Jan 25, 2022
@jbraswell jbraswell deleted the trailing-metadata branch January 25, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants