Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-recording bug #999

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Mar 15, 2022

Description

This fixes the bug introduced in both the tornado and flask instrumentations

Fix #998

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@codeboten codeboten requested a review from a team March 15, 2022 15:35
@codeboten codeboten changed the title opentelemetry-instrumentation-flask fix recording bug fix non-recording bug Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NonRecordingSpan' object has no attribute 'kind'
2 participants