Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous gauge prototype #3462

Merged
merged 9 commits into from
Feb 5, 2024

Conversation

sarafonseca-123
Copy link
Contributor

@sarafonseca-123 sarafonseca-123 commented Oct 5, 2023

Description

This PR creates a synchronous gauge instrument, based on opentelemetry-java PR Add experimental synchronous gauge #5506. It aims to give support to synchronous gauge as stated on opentelemetry-specification PR Add synchronous gauge instrument, clarify temporality selection influence on metric point persistence #3540.

Fixes # (issue)
#3363

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This change was tested with multiple unit tests, that were contributed.
Also, it was locally tested with a simple API in Flask integrating with an OTEL server deployed on Kubernetes, using Python 3.8.

image image

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@sarafonseca-123 sarafonseca-123 marked this pull request as ready for review October 5, 2023 22:27
@sarafonseca-123 sarafonseca-123 requested a review from a team October 5, 2023 22:27
@ohaibbq
Copy link

ohaibbq commented Nov 7, 2023

These changes seem good to me! 🎉
@ocelotl @lzchen how can I help push this PR forward?

docs/getting_started/metrics_example.py Outdated Show resolved Hide resolved
@ocelotl
Copy link
Contributor

ocelotl commented Dec 14, 2023

Well done! ✌️

@agronholm
Copy link

What's the status on this? I would very much like to get my hands on the synchronous gauge API.

@agronholm
Copy link

@sarafonseca-123 Why did you make Gauge private? Isn't the whole point here to provide that API to end users?

@agronholm
Copy link

agronholm commented Feb 1, 2024

@sarafonseca-123 Why did you make Gauge private? Isn't the whole point here to provide that API to end users?

Oh, because it's experimental? I only just now saw that in the resolved comments.

@ocelotl ocelotl enabled auto-merge (squash) February 3, 2024 18:28
auto-merge was automatically disabled February 3, 2024 18:31

Pull Request is not mergeable

@ocelotl ocelotl enabled auto-merge (squash) February 3, 2024 19:25
auto-merge was automatically disabled February 3, 2024 19:30

Pull Request is not mergeable

auto-merge was automatically disabled February 3, 2024 19:30

Pull Request is not mergeable

@agronholm
Copy link

The only thing missing here seems to be one leftover reference in the docs to Gauge that should be _Gauge instead.

@ocelotl ocelotl enabled auto-merge (squash) February 5, 2024 18:30
@ocelotl ocelotl merged commit 66e7d61 into open-telemetry:main Feb 5, 2024
270 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants