Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set span status on wsgi errors #864

Merged
merged 5 commits into from
Jul 7, 2020
Merged

Set span status on wsgi errors #864

merged 5 commits into from
Jul 7, 2020

Conversation

jan25
Copy link
Contributor

@jan25 jan25 commented Jun 27, 2020

Set INTERNAL error span status for unhandled uwsgi exceptions before calling span.end().

Fixes #846

@jan25
Set span status on uwsgi errors
051b4fc 
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@jan25
Undo not needed change
bd32c17 
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@jan25
Undo not needed change
9ccee0e 
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@jan25 jan25 requested a review from a team June 27, 2020 16:40
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 27, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@jan25 jan25 closed this Jun 27, 2020
@jan25 jan25 reopened this Jun 27, 2020
@jan25 jan25 closed this Jun 27, 2020
@jan25 jan25 reopened this Jun 27, 2020
@jan25
Copy link
Contributor Author

jan25 commented Jun 27, 2020

Sorry about closing, wanted to make sure CLAs are checked.

lzchen
lzchen approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

codeboten
codeboten suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jan25! If you could update the CHANGELOG in /ext/opentelemetry-ext-wsgi, I'll be happy to approve and merge after

@jan25
Copy link
Contributor Author

jan25 commented Jun 29, 2020 •
edited
Loading

@codeboten thanks for the review! Is there a tool/command to add CHANGELOG entry? Also, maybe a good idea to mention about this in CONTRIBUTING.md?

@jan25
Update changelog
5d63428 
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
codeboten
codeboten approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changelog update!

@codeboten codeboten merged commit c0a5be5 into open-telemetry:master Jul 7, 2020
codeboten pushed a commit that referenced this pull request Jul 7, 2020
@jan25
ext/wsgi: Set span status on wsgi errors (#864)
9c5e520
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@dyladan
Add feature status to readme (open-telemetry#864)
697fb60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wsgi: set error status on span
3 participants
@jan25 @codeboten @lzchen