gRPC Client Metrics and Protobuf testing for client #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnnradams
force-pushed
the
grpc_metrics_tests
branch
8 times, most recently
from
d3591b1
to
e6afc55
Compare
cnnradams
force-pushed
the
grpc_metrics_tests
branch
from
e6afc55
to
bfc6370
Compare
|
closing in favor of #896 and a future PR for metrics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics
duration,bytes_in,bytes_outanderrorsare recorded. I also added tests for the gRPC client, since there were none previously.In terms of documentation, I will add it when #788 is merged (or it can add it itself)
question I have: The proto/client for the test case were mainly taken from the gRPC repo, which license should be used at the top? (grpc or OT?)