Handle B3 trace_id and span_id correctly #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srjames90
reviewed
Jul 23, 2020
srjames90
approved these changes
Jul 30, 2020
aabmass
reviewed
Aug 4, 2020
opentelemetry-sdk/src/opentelemetry/sdk/trace/propagation/b3_format.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/propagation/b3_format.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Aug 5, 2020
| @@ -95,19 +97,34 @@ def extract( | |||
| or flags | |||
| ) | |||
|
|
|||
| if ( | |||
| fullmatch(r"[\da-fA-F]{16}|[\da-fA-F]{32}", trace_id) is None | |||
There was a problem hiding this comment.
Can we get a test case for this?
Fixes open-telemetry#933 These fields are not being handled correctly when one or both of them receive invalid values.
lzchen
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933
These fields are not being handled correctly when one or both of them
receive invalid values.