Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename web framework packages from "ext" to "instrumentation" #961

Merged
merged 38 commits into from
Aug 3, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jul 30, 2020

Description

Part of [#760]. Renaming web related packages.

Checklist:

  1. changelogs

  2. folder name ext -> subfolder ext

  3. setup.cfg/setup.py

  4. tox

  5. README

@lzchen lzchen requested a review from a team July 30, 2020 08:42
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, just some minor comments/suggestions, mostly nits.

@lzchen lzchen merged commit 28d0cdf into open-telemetry:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants