Fix dropped metrics instruments #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtescher
changed the title
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 49.39% 49.40% +0.01%
==========================================
Files 66 66
Lines 5416 5416
==========================================
+ Hits 2675 2676 +1
+ Misses 2741 2740 -1
Continue to review full report at Codecov.
|
TommyCpp
reviewed
Dec 31, 2020
| @@ -6,6 +6,33 @@ use opentelemetry::{ | |||
| use opentelemetry_prometheus::PrometheusExporter; | |||
| use prometheus::{Encoder, TextEncoder}; | |||
|
|
|||
| #[test] | |||
| fn free_unused_instruments() { | |||
There was a problem hiding this comment.
Hmm for some reason when I run this test against master it works. Not sure if I missed something.
There was a problem hiding this comment.
This behavior seems to have changed between dashmap version 4.0.0-rc6 and dashmap version 4.0.0 which was released this week. If you cargo update you should see the issue.
TommyCpp
approved these changes
Dec 31, 2020
| @@ -6,6 +6,33 @@ use opentelemetry::{ | |||
| use opentelemetry_prometheus::PrometheusExporter; | |||
| use prometheus::{Encoder, TextEncoder}; | |||
|
|
|||
| #[test] | |||
| fn free_unused_instruments() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently metrics can deadlock when dropping the last reference to an instrument. This patch addresses this by switching to
https://docs.rs/dashmap/4.0.1/dashmap/struct.DashMap.html#method.retain.Related #397