feat: using Cow<'static, str>
for instrumentation library.
#670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows users to pass in a
String
if needed, although it will have a performance overhead because we need to clone the string every time a span gets exported. I did a quick test and it seems the overhead is manageable. Less than 10%Users that pass a
'static str
will not be impacted asCow::Borrow
just copies the pointer.Fix #666