-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix span processor exporting unsampled spans #871
Fix span processor exporting unsampled spans #871
Conversation
Currently span processors will send span data to exporters even if the sampled flag is false. This patch fixes this by explicitly checking the sampled state in both the batch and simple span processors.
Codecov ReportBase: 66.8% // Head: 66.6% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
- Coverage 66.8% 66.6% -0.2%
=======================================
Files 113 113
Lines 8775 8798 +23
=======================================
- Hits 5866 5864 -2
- Misses 2909 2934 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic LGTM. Maybe better if we have some unit tests to prevent regression in the future?
@TommyCpp added a regression test 👍 |
Sorry took a look yesterday but forgot to approve |
@TommyCpp All good, thanks for the review 🥳 |
Currently span processors will send span data to exporters even if the sampled flag is false. This patch fixes this by explicitly checking the sampled state in both the batch and simple span processors.
Fixes #870