reformatted tracing-api.md and added TOC. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rghetia
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
|
i signed it |
songy23
approved these changes
Jun 14, 2019
bogdandrutu
reviewed
Jun 14, 2019
|
|
||
| There should be no parameter. | ||
|
|
||
| Returns the default `Span` that does nothing and has an invalid `SpanContext` if no | ||
| `Span` is associated with the current context, otherwise the current `Span` from the context. | ||
|
|
||
| #### `WithSpan`: enters the scope of code where the given `Span` is in the current context. | ||
| #### WithSpan | ||
| enters the scope of code where the given `Span` is in the current context. |
There was a problem hiding this comment.
Because this is a sentence should we start with upper case letter?
There was a problem hiding this comment.
yes. I'll send a new PR.
|
I'm merging. @rghetia when you have a moment - please send a separate PR to uppercase first |
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
rockb1017
pushed a commit
to rockb1017/opentelemetry-specification
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resubmitting #116 after changing email on CLA.