Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify async instrument callback identity #2538

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Clarify async instrument callback identity #2538

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dce9e46
Clarify async instrument callback identity
legendecas May 13, 2022
0051b11
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas May 20, 2022
f88f232
Merge branch 'main' into metric-callback
legendecas May 21, 2022
0184309
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas Jun 10, 2022
21e5fce
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas Jun 21, 2022
42d0725
fixup!
legendecas Jun 21, 2022
51b8d75
fixup!
legendecas Jun 21, 2022
2379e34
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas Jul 4, 2022
572aec4
Merge branch 'main' into metric-callback
jmacd Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ release.

### Metrics

- Clarify async instrument callback identity.
([#2538](https://github.com/open-telemetry/opentelemetry-specification/pull/2538)).

### Logs

### Resource
Expand Down
7 changes: 4 additions & 3 deletions specification/metrics/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,10 @@ Where the API supports registration of `callback` functions after
asynchronous instrumentation creation, the user MUST be able to undo
registration of the specific callback after its registration by some means.

Every currently registered Callback associated with an instrument MUST
be evaluted exactly once during collection prior to reading data for
that instrument.
Every registered Callback associated with a set of instruments MUST
be evaluated exactly once during collection prior to reading data for
that instrument. The evaluation is identified using a combination of the
legendecas marked this conversation as resolved.
Show resolved Hide resolved
callback itself, and the instruments set.
jmacd marked this conversation as resolved.
Show resolved Hide resolved

Callback functions MUST be documented as follows for the end user:

Expand Down