-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide clear guidance on what semconv actually enforces #3225
Conversation
…by semconv that can be included in stability.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Johannes Tax <johannes@johannes.tax>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this @jsuereth
I think it is important to define precisely what we guarantee.
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
…`faas.max_memory` (open-telemetry#3209)
* Add connect_rpc to rpc.yaml * Add connect rpc into rpc-metrics and rpc markdown * Add Connect RPC change to CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objection to additions done in the PR, but I still have concern wrt schema transformation and how/if it can really guarantee stability and work along with this PR.
I created #3296 and suggest that we keep schema transformations experimental with possibility to stabilize it in the future independently of current efforts to stabilize HTTP semconv.
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Fixes #2864
Fixes #2883
Changes
Context
Sig discussion thread/doc here.