Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put hiatus on semantic conventions until they are in the new repository. #3489

Merged
merged 9 commits into from
May 11, 2023
Merged

Put hiatus on semantic conventions until they are in the new repository. #3489

merged 9 commits into from
May 11, 2023

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented May 9, 2023

@jsuereth
Put hiatus on semantic conventions until they are in the new repository.
59cf92e
@jsuereth
Add spec<->semconv callouts.
6e51975 
- Define attributes required by specification
- reserver otel namespace for the specification
- Update links.
pyohannes
pyohannes reviewed May 9, 2023
View reviewed changes
specification/semantic-conventions.md Outdated Show resolved Hide resolved
specification/semantic-conventions.md Outdated Show resolved Hide resolved
@jsuereth jsuereth marked this pull request as ready for review May 9, 2023 20:53
@jsuereth jsuereth requested review from a team May 9, 2023 20:53
reyang
reyang approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left couple comments/suggestions, nothing blocking since the specs are still Experimental (and I think what's more important is to get the NOTICE out ASAP).

@reyang reyang mentioned this pull request May 9, 2023
Merged
joaopgrassi
joaopgrassi approved these changes May 10, 2023
View reviewed changes
specification/overview.md Show resolved Hide resolved
@jsuereth jsuereth mentioned this pull request May 10, 2023
Closed
arminru
arminru approved these changes May 10, 2023
View reviewed changes
specification/logs/semantic_conventions/README.md Show resolved Hide resolved
specification/semantic-conventions.md Show resolved Hide resolved
specification/trace/exceptions.md Show resolved Hide resolved
@marcalff marcalff mentioned this pull request May 11, 2023
Closed
@carlosalberto carlosalberto merged commit 6a57f09 into open-telemetry:main May 11, 2023
@jsuereth jsuereth deleted the pr-semconv-hiatus branch May 12, 2023 12:06
@kamalmarhubi kamalmarhubi mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@lmolkova lmolkova lmolkova approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@MrAlias MrAlias MrAlias approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@arminru arminru arminru approved these changes

@pyohannes pyohannes pyohannes approved these changes

@jamesmoessis jamesmoessis jamesmoessis approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jsuereth @carlosalberto @lmolkova @tigrannajaryan @MrAlias @joaopgrassi @arminru @pyohannes @reyang @jamesmoessis