Metric namespaces should not be pluralized #3663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
metric-namespace-pluralization
branch
from
3d1747d
to
6f2c8f6
Compare
reyang
approved these changes
Aug 15, 2023
arminru
approved these changes
Aug 17, 2023
|
Closing, as @jack-berg pointed out this PR should be made against semantic-conventions repo 😅 |
|
@open-telemetry/specs-semconv-maintainers we'll have to remove the left-over pages in the spec repo (either entirely or by just leaving a link to the new location in each of them) at some point to avoid accidentally merging changes into the abandoned parts here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/semantic-conventions#212
Changes
Metric namespaces SHOULD NOT be pluralized.
This affect these current metric namespaces:
system.processes.count->system.process.countsystem.processes.created->system.process.createddb.client.connections.*->db.client.connection.*jvm.threads.count->jvm.thread.countjvm.classes.count->jvm.class.count