Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(concurrentbatchprocessor): adds mib suffix to max bytes setting #121

Merged
merged 2 commits into from
Dec 18, 2023
Merged

(concurrentbatchprocessor): adds mib suffix to max bytes setting #121

merged 2 commits into from
Dec 18, 2023

Conversation

moh-osman3
Copy link
Contributor

Fixes #109

@moh-osman3 moh-osman3 changed the title (concurrentbatchprocessor): adds suffix, changes setting from max_in_flight_bytes to max_in_flight_bytes_mib (concurrentbatchprocessor): adds mib suffix to max bytes setting Dec 13, 2023
@moh-osman3 moh-osman3 marked this pull request as ready for review December 13, 2023 08:34
lquerel
lquerel approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd merged commit d1eb6a1 into open-telemetry:main Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lquerel lquerel lquerel approved these changes

@jmacd jmacd jmacd approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure MaxInFlightBytes using MiB for concurrentbatchprocessor
3 participants
@moh-osman3 @lquerel @jmacd