Introduce Entities Data Model, Part 1 #256
Conversation
tigrannajaryan
force-pushed
the
feature/tigran/entity-datamodel-step1
branch
from
6d05d5d
to
b997c42
Compare
This is a proposal of a data model to represent entities. The purpose of the data model is to have a common understanding of what an entity is, what data needs to be recorded, transferred, stored and interpreted by an entity observability system. This data model sets the foundation for adding entities to OpenTelemetry. The data model is largely borrowed from [the initial proposal](https://docs.google.com/document/d/1VUdBRInLEhO_0ABAoiLEssB1CQO_IcD5zDnaMEha42w/edit) that was accepted for entities SIG formation. This OTEP is step 1 in introducing the entities data model. Follow up OTEPs will add further data model definitions, including the linking of Resource information to entities.
tigrannajaryan
force-pushed
the
feature/tigran/entity-datamodel-step1
branch
from
b997c42
to
9227cfc
Compare
|
@open-telemetry/specs-approvers please review. |
There was a problem hiding this comment.
This new concept is great, and (I think) it provides a much more elegant solution to how we can model frequently-changing, mutable state(s) that have an outsized impact of how mobile applications run in production. The ability to model network connections, OS resource provisioning (e.g. CPU throttling, process priority, etc.), concurrent app execution, OS services and state, etc. as one or more entities in a consistent, semantic convention'd manner will go a long way into standardizing the execution context of mobile apps, something we sorely need.
|
All reviewers, thank you for your comments and improvement suggestions. I think I addressed all questions. I will keep the PR open for 2 more business days and will merge after that if I see no objections. |
|
2 business days since last change. All comments addressed and resolved. We have enough approvals. Merging. |
|
|
||
| ```json5 | ||
| { | ||
| "process.pid": 12345, |
There was a problem hiding this comment.
Hi @tigrannajaryan, I know this is only an example, but I'd like to point out this won't be sufficient for a unique process entity ID on Windows.
On Windows, PIDS can be re-used in less than 1s, so to be unique, the start time could be more precise (nanoseconds), or more attributes are needed
There was a problem hiding this comment.
Yes, just an example and thanks for pointing out. We will work on this most likely within the semconv group when the Entities SIG makes a bit more progress on the basics.
This is a proposal of a data model to represent entities. The purpose of the data model is to have a common understanding of what an entity is, what data needs to be recorded, transferred, stored and interpreted by an entity observability system.
This data model sets the foundation for adding entities to OpenTelemetry. The data model is largely borrowed from
the initial proposal that was accepted for entities SIG formation.
This OTEP is step 1 in introducing the entities data model. Follow up OTEPs will add further data model definitions, including the linking of Resource information to entities.