Skip to content

Commit

Permalink
review changes
Browse files Browse the repository at this point in the history
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
  • Loading branch information
ChrsMark committed Aug 24, 2023
1 parent 62b4273 commit 5247d16
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ release.
([#252](https://github.com/open-telemetry/semantic-conventions/pull/252))
- Simplify HTTP metric briefs.
([#276](https://github.com/open-telemetry/semantic-conventions/pull/276))
- Add more ECS url fields.
([#181](https://github.com/open-telemetry/semantic-conventions/pull/181))

## v1.21.0 (2023-07-13)

Expand Down
12 changes: 6 additions & 6 deletions model/url.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ groups:
- id: registered_domain
requirement_level: opt_in
type: string
brief: >
brief: |
The highest registered url domain, stripped of the subdomain.
For example, the registered domain for "foo.example.com" is "example.com".
Expand All @@ -52,7 +52,7 @@ groups:
- id: subdomain
requirement_level: opt_in
type: string
brief: >
brief: |
The subdomain portion of a fully qualified domain name includes all of
the names except the host name under the registered_domain. In a partially
qualified domain, or if the the qualification level of the full name cannot
Expand All @@ -65,7 +65,7 @@ groups:
- id: top_level_domain
requirement_level: opt_in
type: string
brief: >
brief: |
The effective top level domain (eTLD), also known as the domain suffix,
is the last part of the domain name. For example, the top level domain
for example.com is "com".
Expand All @@ -87,7 +87,7 @@ groups:
- id: extension
requirement_level: opt_in
type: string
brief: >
brief: |
The field contains the file extension from the original request url,
excluding the leading dot.
Expand All @@ -103,7 +103,7 @@ groups:
- id: domain
requirement_level: opt_in
type: string
brief: >
brief: |
Domain of the url, such as `www.opentelemetry.io`.
In some cases a URL may refer to an IP and/or port directly,
Expand All @@ -120,7 +120,7 @@ groups:
- id: original
requirement_level: opt_in
type: string
brief: >
brief: |
Unmodified original URL as seen in the event source.
Note that in network monitoring, the observed URL may be
Expand Down

0 comments on commit 5247d16

Please sign in to comment.