Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed May 4, 2024
1 parent 04f050d commit 86ee3c9
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 72 deletions.
14 changes: 6 additions & 8 deletions docs/messaging/messaging-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@
<!-- toc -->

- [Common attributes](#common-attributes)
- [Metric: `messaging.client.operation.duration`](#metric-messagingclientoperationduration)
- [Producer metrics](#producer-metrics)
- [Metric: `messaging.publish.duration`](#metric-messagingpublishduration)
- [Metric: `messaging.publish.messages`](#metric-messagingpublishmessages)
- [Metric: `messaging.client.published.messages`](#metric-messagingclientpublishedmessages)
- [Consumer metrics](#consumer-metrics)
- [Metric: `messaging.receive.duration`](#metric-messagingreceiveduration)
- [Metric: `messaging.receive.messages`](#metric-messagingreceivemessages)
- [Metric: `messaging.process.duration`](#metric-messagingprocessduration)
- [Metric: `messaging.process.messages`](#metric-messagingprocessmessages)
- [Metric: `messaging.client.consumed.messages`](#metric-messagingclientconsumedmessages)
- [Metric: `messaging.consumer.process.duration`](#metric-messagingconsumerprocessduration)

<!-- tocstop -->

Expand Down Expand Up @@ -101,7 +99,7 @@ This metric is [required][MetricRequired].
When this metric is reported alongside a messaging span, the metric value SHOULD be the same as the corresponding span duration.

This metric applies measures duration of operations that application initiates to communicate with the broker. It SHOULD NOT be used
to report processing duration. Processing is covered by [`messaging.consumer.process.duration`](#metric-messagingprocessduration) metric.
to report processing duration. Processing is covered by [`messaging.consumer.process.duration`](#metric-messagingconsumerprocessduration) metric.

This metric SHOULD be specified with
[`ExplicitBucketBoundaries`](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.31.0/specification/metrics/api.md#instrument-advice)
Expand Down Expand Up @@ -152,7 +150,7 @@ _Note: The need to report `messaging.client.consumed.messages` depends on the me

This metric is [required][MetricRequired] for operations that are not initiated by the application code (push-based deliver), and [recommended][MetricRecommended] for processing operations instrumented for pull-based scenarios.

Processing operation covers application-specific message processing logic and errors. Processing duration SHOULD NOT be reported as a part of the [`messaging.consumer.process.duration`](#metric-messagingclientoperationduration).
Processing operation covers application-specific message processing logic and errors. Processing duration SHOULD NOT be reported as a part of the [`messaging.client.operation.duration`](#metric-messagingclientoperationduration).

When this metric is reported alongside a messaging process span, the metric value SHOULD be the same as the corresponding span duration.

Expand Down
4 changes: 2 additions & 2 deletions docs/messaging/messaging-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
- [Conventions](#conventions)
- [Context propagation](#context-propagation)
- [Span name](#span-name)
- [Operation types](#operation-types)
- [Common messaging operations](#common-messaging-operations)
- [Span kind](#span-kind)
- [Trace structure](#trace-structure)
- [Producer spans](#producer-spans)
Expand Down Expand Up @@ -157,7 +157,7 @@ Messaging spans MUST follow the overall [guidelines for span names](https://gith

<!-- markdown-link-check-disable -->
<!-- HTML anchors are not supported https://github.com/tcort/markdown-link-check/issues/225-->
The **span name** SHOULD be `{messaging.operation.name} {destination}` (see below for the exact definition of the [`{target}`](#target-placeholder) placeholder).
The **span name** SHOULD be `{messaging.operation.name} {destination}` (see below for the exact definition of the [`{destination}`](#destination-placeholder) placeholder).
<!-- markdown-link-check-enable -->

Semantic conventions for individual messaging systems MAY specify different span name format and then MUST document it in [semantic conventions for specific messaging technologies](#semantic-conventions-for-specific-messaging-technologies).
Expand Down
1 change: 0 additions & 1 deletion model/messaging-common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ groups:
- ref: server.port
- ref: messaging.operation.name
requirement_level: required

60 changes: 0 additions & 60 deletions model/metrics/deprecated/messaging-metrics-deprecated.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion model/metrics/deprecated/messaging-metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ groups:
stability: experimental
instrument: counter
unit: "{message}"
extends: metric.messaging.attributes
extends: metric.messaging.attributes

0 comments on commit 86ee3c9

Please sign in to comment.