review

open-telemetry · Jun 11, 2024 · b6008e8 · b6008e8
1 parent 0cf9fc4
commit b6008e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/docs/messaging/messaging-metrics.md b/docs/messaging/messaging-metrics.md
@@ -171,7 +171,7 @@ This metric is [required][MetricRequired].
 | `messaging.client.published.messages` | Counter | `{message}` | Number of messages producer attempted to publish to the broker. [1] | ![Experimental](https://img.shields.io/badge/-experimental-blue) |
 
 
-**[1]:** This metric MUST NOT count messages that were created, but aren't being published yet.
+**[1]:** This metric MUST NOT count messages that were created haven't yet been attempted to be published.
 
 
 
@@ -282,7 +282,7 @@ This metric is [required][MetricRequired].
 
 
 **[1]:** Records the number of messages pulled from the broker or number of messages dispatched to the application in push-based scenarios.
-The metric MUST be reported once per message delivery. For example, if receiving and processing operations are both instrumented for a single message delivery, the number of received messages is reported when then message is received and not reported for the processing operation.
+The metric SHOULD be reported once per message delivery. For example, if receiving and processing operations are both instrumented for a single message delivery, this counter is incremented when the message is received and not reported when it is processed.
 
 
 

diff --git a/model/metrics/messaging-metrics.yaml b/model/metrics/messaging-metrics.yaml
@@ -53,7 +53,7 @@ groups:
     metric_name: messaging.client.published.messages
     brief: "Number of messages producer attempted to publish to the broker."
     note: >
-      This metric MUST NOT count messages that were created, but aren't being published yet.
+      This metric MUST NOT count messages that were created haven't yet been attempted to be published.
     stability: experimental
     instrument: counter
     unit: "{message}"
@@ -69,8 +69,9 @@ groups:
     note: >
       Records the number of messages pulled from the broker or number of messages dispatched to the application in push-based scenarios.
 
-      The metric MUST be reported once per message delivery. For example, if receiving and processing operations are both instrumented for a single message delivery, the number of received messages
-      is reported when then message is received and not reported for the processing operation.
+      The metric SHOULD be reported once per message delivery. For example, if receiving and
+      processing operations are both instrumented for a single message delivery, this counter
+      is incremented when the message is received and not reported when it is processed.
     stability: experimental
     instrument: counter
     unit: "{message}"