Skip to content

Commit

Permalink
remove changes not related to metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Jun 14, 2023
1 parent 9cc98b8 commit d27bada
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
6 changes: 2 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ release.
([#55](https://github.com/open-telemetry/semantic-conventions/pull/55))
- Split out sections for proposed stable JVM metrics and experimental JVM metrics.
([#56](https://github.com/open-telemetry/semantic-conventions/pull/56))
- Change attributes requirement levels on HTTP server semantic conventions:
`server.address` and `server.port` requirement level has changed from
`required` to `opt_in` on HTTP server metrics and to `recommended` on HTTP server spans,
`url.query` requirement level has changed from `recommended` to `required`.
- Change `server.address` and `server.port` requirement levels on HTTP server metrics
from `required` to `opt_in`.
([#109](https://github.com/open-telemetry/semantic-conventions/pull/109))
6 changes: 3 additions & 3 deletions semantic_conventions/trace/http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ groups:
brief: 'Semantic Convention for HTTP Server'
attributes:
- ref: server.address
requirement_level: recommended
requirement_level: required
sampling_relevant: true
brief: >
Name of the local HTTP server that received the request.
Expand All @@ -104,7 +104,7 @@ groups:
- ref: server.port
sampling_relevant: true
requirement_level:
recommended: If not default (`80` for `http` scheme, `443` for `https`).
conditionally_required: If not default (`80` for `http` scheme, `443` for `https`).
brief: >
Port of the local HTTP server that received the request.
note: |
Expand Down Expand Up @@ -138,7 +138,7 @@ groups:
requirement_level: required
sampling_relevant: true
- ref: url.query
requirement_level: required
requirement_level: recommended
sampling_relevant: true
- ref: url.scheme
requirement_level: required
Expand Down
6 changes: 3 additions & 3 deletions specification/trace/semantic_conventions/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -293,12 +293,12 @@ If the route cannot be determined, the `name` attribute MUST be set as defined i
| [`client.port`](span-general.md) | int | The port of the original client behind all proxies, if known (e.g. from [Forwarded](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded) or a similar header). Otherwise, the immediate client peer port. [3] | `65123` | Recommended |
| [`client.socket.address`](span-general.md) | string | Immediate client peer address - unix domain socket name, IPv4 or IPv6 address. | `/tmp/my.sock`; `127.0.0.1` | Recommended: If different than `client.address`. |
| [`client.socket.port`](span-general.md) | int | Immediate client peer port number | `35555` | Recommended: If different than `client.port`. |
| [`server.address`](span-general.md) | string | Name of the local HTTP server that received the request. [4] | `example.com` | Recommended |
| [`server.port`](span-general.md) | int | Port of the local HTTP server that received the request. [5] | `80`; `8080`; `443` | Recommended: [6] |
| [`server.address`](span-general.md) | string | Name of the local HTTP server that received the request. [4] | `example.com` | Required |
| [`server.port`](span-general.md) | int | Port of the local HTTP server that received the request. [5] | `80`; `8080`; `443` | Conditionally Required: [6] |
| [`server.socket.address`](span-general.md) | string | Local socket address. Useful in case of a multi-IP host. | `10.5.3.2` | Opt-In |
| [`server.socket.port`](span-general.md) | int | Local socket port. Useful in case of a multi-port host. | `16456` | Opt-In |
| `url.path` | string | The [URI path](https://www.rfc-editor.org/rfc/rfc3986#section-3.3) component [7] | `/search` | Required |
| `url.query` | string | The [URI query](https://www.rfc-editor.org/rfc/rfc3986#section-3.4) component [8] | `q=OpenTelemetry` | Required |
| `url.query` | string | The [URI query](https://www.rfc-editor.org/rfc/rfc3986#section-3.4) component [8] | `q=OpenTelemetry` | Recommended |
| `url.scheme` | string | The [URI scheme](https://www.rfc-editor.org/rfc/rfc3986#section-3.1) component identifying the used protocol. | `http`; `https` | Required |

**[1]:** MUST NOT be populated when this is not supported by the HTTP server framework as the route attribute should have low-cardinality and the URI path can NOT substitute it.
Expand Down

0 comments on commit d27bada

Please sign in to comment.