Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.route to http.request.route? #378

Closed
trask opened this issue Oct 11, 2023 · 7 comments
Closed

Rename http.route to http.request.route? #378

trask opened this issue Oct 11, 2023 · 7 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Oct 11, 2023

After #374, http.route will be the only http.* attribute that is not under either http.request.* or http.response.*.

I think I'm in favor of keeping http.route as-is, but wanted to open this to give others a chance to weigh in if they feel differently.

@cartermp
Copy link
Contributor

I would agree with not changing it. In particular we have customers who rely on checking http.route contents via something like a Contains operator, and this is the basis for things like SLOs, Alerts, etc. with no obvious way to migrate when it's split in two. The other changes (that customers are affected by, at least) are 1:1 translations that are easier to perform on our backend.

@cartermp
Copy link
Contributor

Ah, right, sorry, I got confused and was thinking of http.target, which is being split. E_TOO_MANY_HTTP_SEMANTIC_CONVENTIONS.

I'm...ambivalent I guess, since whatever process we have to convert on the backend can work for http.route if it changes to a single attribute. But the less change, the better?

@Oberon00
Copy link
Member

Oberon00 commented Oct 12, 2023

(Aside: It is unclear what the upvotes on the issue mean. "Yes" to the question in the issue title whether we should rename, or "Agree" to the sentence in the description that we should rather keep the name as-is)

@joaopgrassi
Copy link
Member

I'm also in favor of not changing and keep it as-is.

@JamesNK
Copy link

JamesNK commented Oct 12, 2023

Keep it as http.route. The route isn't information on the request. It is calculated on the server.

@joaopgrassi
Copy link
Member

I guess we have a majority on keeping it as http.route? Do you think we can close this @trask? Or you want to bring it up in the meeting before?

@trask
Copy link
Member Author

trask commented Oct 16, 2023

The route isn't information on the request. It is calculated on the server.

closing, this is a great reason to keep it where it is, thx @JamesNK

@trask trask closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

6 participants