Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename http.resend_count to http.request.resend_count #374

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

trask
Copy link
Member

@trask trask commented Oct 10, 2023

Changes

Renames http.resend_count to http.request.resend_count to be consistent with http.request.method, http.response.status_code, and other http attributes which are generally prefixed with http.request.* or http.response.*.

Merge requirement checklist

@trask trask changed the title Rename http.resend_count to http.request.resend_count Rename http.resend_count to http.request.resend_count Oct 10, 2023
@trask trask marked this pull request as ready for review October 10, 2023 19:30
@trask trask requested review from a team October 10, 2023 19:30
@AlexanderWert AlexanderWert merged commit d21d653 into open-telemetry:main Oct 16, 2023
9 checks passed
@trask trask deleted the rename-http-resend-count branch October 16, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants