Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics semconv should include value type of instrument and requirement levels in yaml and md #591

Open
lmolkova opened this issue Dec 7, 2023 · 2 comments
Assignees

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Dec 7, 2023

Metric-specific properties (in yaml) are limited to metric_name, instrument, and unit:

We never document the value type (long or float) in yaml or markdown files.

As a result code generation cannot really generate metric definitions and we leave a wiggle room for instrumentation to decide on (and change) the value type.

Also, we manually include requirement level into md.

We should

  • extend metric yaml schema to include
  • update existing metric definitions in the spec
@lmolkova
Copy link
Contributor Author

lmolkova commented Dec 7, 2023

related to #551, open-telemetry/oteps#243

@joaopgrassi
Copy link
Member

Also related to #1040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Improve YAML Schema
Development

No branches or pull requests

3 participants