New semconvgen templates prototype #5156
Conversation
| /// <summary> | ||
| /// Describes semantic conventions for attributes in the <c>cloudevents</c> namespace. | ||
| /// </summary> | ||
| public static class CloudeventsAttributes |
There was a problem hiding this comment.
cloudevents, graphql, webengine, opentracing, etc cannot be automatically CamelCased, so need to figure out something on the semconv side to fix it across languages
There was a problem hiding this comment.
| /// <remarks> | ||
| /// When observed from the server side, and when communicating through an intermediary, <c>client.address</c> SHOULD represent the client address behind any intermediaries, for example proxies, if it&#39;s available. | ||
| /// </remarks> | ||
| public const string ClientAddress = "client.address"; |
There was a problem hiding this comment.
Q:
ClientAttributes.ClientAddress vs ClientAttributes.Address ?
| /// <summary> | ||
| /// Describes semantic conventions for attributes in the <c>other</c> namespace. | ||
| /// </summary> | ||
| public static class OtherAttributes |
There was a problem hiding this comment.
todo on the spec side: all attributes must have a namespace
| /// <remarks> | ||
| /// The size of the request payload body in bytes. This is the number of bytes transferred excluding headers and is often, but not always, present as the <a href="https://www.rfc-editor.org/rfc/rfc9110.html#field.content-length">Content-Length</a> header. For requests using transport encoding, this should be the compressed size. | ||
| /// </remarks> | ||
| public static Histogram<double> CreateHttpClientRequestBodySize(Meter meter) |
There was a problem hiding this comment.
value type is not part of yaml - open-telemetry/semantic-conventions#591, so it's not fully possible yet
| -D filter=is_experimental ` | ||
| -D pkg=OpenTelemetry.SemanticConventions.${SPEC_VERSION_ESCAPED} | ||
|
|
||
| #experimental metrics |
There was a problem hiding this comment.
no stable metric yet - open-telemetry/semantic-conventions#587
|
|
||
| #experimental attributes |
There was a problem hiding this comment.
it's easy to filter stable/experimental and move them into different artifacts, use different templates, add [Experimental] attribute, etc
| /// Instrumentations for specific web frameworks that consider HTTP methods to be case insensitive, SHOULD populate a canonical equivalent. | ||
| /// Tracing instrumentations that do so, MUST also set <c>http.request.method_original</c> to the original value. | ||
| /// </remarks> | ||
| public const string HttpRequestMethod = "http.request.method"; |
There was a problem hiding this comment.
Would we want multiple layers like HttpAttributes.Request?
|
I'm slightly worried about the idea that "use whatever is the latest", versus pinning to a specific version. The problem I see is that if I use:
I think having the ability to have (missed the SIG, sorry if it was discussed there) |
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Prototype for new semconv generation approach (that groups attributes by namespace and stability vs semconv)
open-telemetry/semantic-conventions#551
Changes
vX_Y_Z_ExperimentalnamespaceMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes