Make user_agent.original and http.request.header.* attributes sampling relevant on HTTP server spans
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on HTTP server spans
trask
force-pushed
the
more-http-server-sampling-relevant
branch
from
e31cad6
to
f5f43c9
Compare
trask
changed the title
user_agent.original and http.request.header.*` sampling relevant on HTTP server spansuser_agent.original and http.request.header.* sampling relevant on HTTP server spans
trask
force-pushed
the
more-http-server-sampling-relevant
branch
from
f5f43c9
to
1b10d09
Compare
trask
changed the title
user_agent.original and http.request.header.* sampling relevant on HTTP server spansuser_agent.original and http.request.header.* attributes sampling relevant on HTTP server spans
mateuszrzeszutek
approved these changes
Oct 30, 2023
AlexanderWert
approved these changes
Oct 30, 2023
pyohannes
approved these changes
Oct 30, 2023
This was referenced Oct 31, 2023
lmolkova
approved these changes
Nov 1, 2023
jsuereth
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #463
Changes
Makes
user_agent.originalandhttp.request.header.*attributes sampling relevant on HTTP server spans.I think ok to assume headers are available on span start (we already do this for
server.addresswhich is based on host header).Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.