Recommend emitting server.socket.domain only if it's different from s… #94
+16
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
approved these changes
Jun 7, 2023
I can add one; though it seems more like a minor bug fix to me. |
Oberon00
approved these changes
Jun 7, 2023
Oberon00
reviewed
Jun 7, 2023
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
mateuszrzeszutek
force-pushed
the
server.socket.domain-extra-condition
branch
from
ed103bf
to
8aa56ca
Compare
added 2 commits
June 8, 2023 09:54
jsuereth
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erver.address
Resolves #85 (all questions were answered in the issue, this is the only change that stemmed from that)