Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional process fields from ECS #993

Merged
merged 28 commits into from
Aug 3, 2024
Merged

Add additional process fields from ECS #993

merged 28 commits into from
Aug 3, 2024

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented May 1, 2024 •
edited
Loading

Changes

Add additional process fields to the attribute registry, from ECS.

The newly added fields are:

Merge requirement checklist

@mjwolf
Add additional process field from ECS
7976ec6 
Added fields:
* `process.args_count`
* `process.title`
* `process.uptime`
* `process.working_directory`
@mjwolf mjwolf requested review from a team May 1, 2024 21:05
joaopgrassi
joaopgrassi reviewed May 3, 2024
View reviewed changes
model/registry/process.yaml Outdated Show resolved Hide resolved
model/registry/process.yaml Show resolved Hide resolved
@mjwolf mjwolf mentioned this pull request May 15, 2024
Closed
6 tasks
@joaopgrassi
Copy link
Member

Looping in @open-telemetry/semconv-system-approvers as this also adds a process metric.

@mjwolf mjwolf requested a review from a team June 24, 2024 19:45
@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 10, 2024
@github-actions github-actions bot removed the Stale label Jul 11, 2024
lmolkova
lmolkova approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few last cosmetic comments, looks great otherwise

docs/attributes-registry/process.md Outdated Show resolved Hide resolved
model/registry/process.yaml Show resolved Hide resolved
model/metrics/process-metrics.yaml Outdated Show resolved Hide resolved
@mjwolf mjwolf requested a review from a team July 18, 2024 20:14
ChrsMark
ChrsMark approved these changes Jul 26, 2024
View reviewed changes
model/registry/process.yaml Show resolved Hide resolved
model/metrics/process-metrics.yaml Show resolved Hide resolved
@mjwolf
Copy link
Contributor Author

mjwolf commented Aug 1, 2024

I've made a small change to add a note to use at least millisecond precision time to the process.uptime metric. I think the args vs. args_count discussion should be addressed more in the actual resource definition.

I'll wait a few days, if anyone want to discuss it more, then I plan to merge this PR

@lmolkova lmolkova enabled auto-merge (squash) August 3, 2024 19:28
@lmolkova lmolkova merged commit 18b3555 into open-telemetry:main Aug 3, 2024
13 checks passed
@mjwolf mjwolf deleted the process-fields branch August 7, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@joaopgrassi joaopgrassi joaopgrassi left review comments

@braydonk braydonk braydonk left review comments

@trisch-me trisch-me trisch-me approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@joaopgrassi joaopgrassi

Labels
area:security
Projects
Security SemConv
Status: Done
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjwolf @joaopgrassi @lmolkova @trisch-me @ChrsMark @braydonk