Fixes

openPMD · Jun 26, 2024 · b632f9f · b632f9f
1 parent e43369b
commit b632f9f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/examples/14_toml_template.cpp b/examples/14_toml_template.cpp
@@ -20,6 +20,10 @@ void write()
     std::string config = R"(
 {
   "iteration_encoding": "variable_based",
+  "json": {
+    "dataset": {"mode": "template"},
+    "attribute": {"mode": "short"}
+  },
   "toml": {
     "dataset": {"mode": "template"},
     "attribute": {"mode": "short"}

diff --git a/src/IO/JSON/JSONIOHandlerImpl.cpp b/src/IO/JSON/JSONIOHandlerImpl.cpp
@@ -642,14 +642,16 @@ void JSONIOHandlerImpl::createDataset(
             break;
         }
         case IOMode::Template:
-            if (parameter.extent != Extent{0})
+            if (parameter.extent != Extent{0} &&
+                parameter.dtype != Datatype::UNDEFINED)
             {
                 dset["extent"] = parameter.extent;
             }
             else
             {
                 // no-op
-                // If extent is empty, don't bother writing it
+                // If extent is empty or no datatype is defined, don't bother
+                // writing it
             }
             break;
         }