Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow docker secret files for sensitive environment variables #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

freakingawesome
Copy link

This allows you to specify the location of a file to make it easier to use with Docker secrets. If you specify the environment variable directly, it won't try to read from a file.

For example:

portus:
    environment:
        ...
        PORTUS_PRODUCTION_PASSWORD_FILE: /run/secrets/portus-db-root-password
        PORTUS_SECRET_KEY_BASE_FILE: /run/secrets/portus-secret-key-base
        PORTUS_PASSWORD_FILE: /run/secrets/portus-password
        ...

@Nols1000
Copy link

Nols1000 commented Feb 7, 2018

Why has this pull request not yet been merged?

@flavio
Copy link
Member

flavio commented Feb 8, 2018

@mssola can you take a look at that please?

@Vad1mo
Copy link

Vad1mo commented Feb 22, 2018

I don't think this is the right place. It would be easy for Portus to Support docker secretes/files out of the box. Could you open an issue? We will implement it as its also needed for us.

@potzkovge
Copy link

i made an alternative solution which represents more the docker standard used in other repositories #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants