add a final recovery flash after installing the system image #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be optional / deactivatable / activatable either via UI or via config, as it can influence compatibility on some devices. |
tsterbak
reviewed
Dec 29, 2023
| @@ -292,7 +292,12 @@ def adb_twrp_wipe_and_install( | |||
| # if not an a/b-device just stay in twrp | |||
| pass | |||
| else: | |||
| for line in adb_reboot(bin_path=bin_path): | |||
| #recovery might not be installed yet , we reboot to fastboot to flash it | |||
There was a problem hiding this comment.
Here a adb_reboot_recovery would be needed.
But why only flash it afterwards? If flashing twrp directly is save, we could do it directly and run fastboot_flash_recovery to begin with. (like it is done for example for Xiaomi recoveries)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a lot of scenario the recovery is not yet installed after the system installation
This PR ensure that we always flash the recovery after the system to be sure that OTA updates can be done.