Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve querySerializer #1782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petr-like
Copy link

@petr-like petr-like commented Jul 24, 2024

Changes

Added filtering after forming query parameters in querySerialize.

How to Review

Currently, if there is any key in queryParams with an empty object, the result of the generation will include a double ampersand.

For example:

{
      a: 1,
      b: {},
      c: 3,
}

will return => example.com?a=1&&c=3
Because Serialize creates an array with an empty string.

After the improvement, it will be example.com?a=1&c=3

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@petr-like petr-like requested a review from a team as a code owner July 24, 2024 18:10
Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: 4ed7bcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this! But we’ll need to add some test cases ensuring that this fixes problems. I see that it doesn’t fail any tests, but we’ll need to add some too.

@kerwanp kerwanp added the openapi-fetch Relevant to the openapi-fetch library label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openapi-fetch Relevant to the openapi-fetch library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants