Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canadian Postal Codes #38

Closed
amaisonneuve opened this issue May 5, 2015 · 15 comments · Fixed by #167
Closed

Canadian Postal Codes #38

amaisonneuve opened this issue May 5, 2015 · 15 comments · Fixed by #167
Assignees

Comments

@amaisonneuve
Copy link
Contributor

Is there value in adding canadian postal codes to the zipcode table?

I have the full list.

@RussH
Copy link
Member

RussH commented Jun 2, 2015

I don't have a postcode/zipcode db available for the UK - so what use is it? Does it provide distance matching for candidates?

@amaisonneuve
Copy link
Contributor Author

sourcing a UK dB of postal codes is pretty easy. need one?

On June 2, 2015 7:17:10 PM EDT, RussH notifications@github.com wrote:

I don't have a postcode/zipcode db available for the UK - so what use
is it? Does it provide distance matching for candidates?


Reply to this email directly or view it on GitHub:
#38 (comment)

@RussH
Copy link
Member

RussH commented Jun 3, 2015

Sure - just trying to find the value - as I've not used a postal code db
previously

On Wed, 3 Jun 2015 at 00:29 Alain Maisonneuve notifications@github.com
wrote:

sourcing a UK dB of postal codes is pretty easy. need one?

On June 2, 2015 7:17:10 PM EDT, RussH notifications@github.com wrote:

I don't have a postcode/zipcode db available for the UK - so what use
is it? Does it provide distance matching for candidates?


Reply to this email directly or view it on GitHub:
#38 (comment)


Reply to this email directly or view it on GitHub
#38 (comment).

@RussH
Copy link
Member

RussH commented Sep 4, 2015

Hi, thinking about this - if you have the full postalcode db AND it's under a license so that it can be shared then it'd be very useful to include.

@amaisonneuve
Copy link
Contributor Author

OK excellent i will add it.

On Fri, Sep 4, 2015 at 10:56 AM, RussH notifications@github.com wrote:

Hi, thinking about this - if you have the full postalcode db AND it's
under a license so that it can be shared then it'd be very useful to
include.


Reply to this email directly or view it on GitHub
#38 (comment).

@RussH
Copy link
Member

RussH commented Sep 4, 2015

Alain,

looking forward - I suspect we can bin the whole zipcode db and move ot a
google maps lookup?

Such as this?
http://www.hashbangcode.com/blog/find-longitude-and-latitude-postcode-or-zipcode-using-google-maps-and-php
(assuming it's not out of date)


Russ

On 4 September 2015 at 16:28, Alain Maisonneuve notifications@github.com
wrote:

OK excellent i will add it.

On Fri, Sep 4, 2015 at 10:56 AM, RussH notifications@github.com wrote:

Hi, thinking about this - if you have the full postalcode db AND it's
under a license so that it can be shared then it'd be very useful to
include.


Reply to this email directly or view it on GitHub
#38 (comment).


Reply to this email directly or view it on GitHub
#38 (comment).

@RussH
Copy link
Member

RussH commented Sep 7, 2015

Actually - can you drop me an email describing where in the app you use this functionality? Just trying to see if the zipcode.php replacement works with google maps lookup. But as I've never used this functionality, I can't see where you "enter a zipcode and find near candidates?" or is the functionality slightly different?

@amaisonneuve
Copy link
Contributor Author

The functionality is on the 'Edit' Candidates page. there are a few
enhancements i'm working on for that page.

In terms of the candidate 'Search' thats actually not a bad idea. and
wouldn't be to difficult to build.

On Mon, Sep 7, 2015 at 8:19 AM, RussH notifications@github.com wrote:

Actually - can you drop me an email describing where in the app you use
this functionality? Just trying to see if the zipcode.php replacement works
with google maps lookup. But as I've never used this functionality, I can't
see where you "enter a zipcode and find near candidates?" or is the
functionality slightly different?


Reply to this email directly or view it on GitHub
#38 (comment).

@RussH
Copy link
Member

RussH commented Sep 10, 2015

I only asked on 'distance from jobs to candidates' as I see there is
commented out code in ziplookup.php to calculate distance for candidates -
but there's no functionality in the app to actually use it. I guess it was
planned functionality..


Russ

On 9 September 2015 at 21:24, Alain Maisonneuve notifications@github.com
wrote:

The functionality is on the 'Edit' Candidates page. there are a few
enhancements i'm working on for that page.

In terms of the candidate 'Search' thats actually not a bad idea. and
wouldn't be to difficult to build.

On Mon, Sep 7, 2015 at 8:19 AM, RussH notifications@github.com wrote:

Actually - can you drop me an email describing where in the app you use
this functionality? Just trying to see if the zipcode.php replacement
works
with google maps lookup. But as I've never used this functionality, I
can't
see where you "enter a zipcode and find near candidates?" or is the
functionality slightly different?


Reply to this email directly or view it on GitHub
#38 (comment).


Reply to this email directly or view it on GitHub
#38 (comment).

@RussH
Copy link
Member

RussH commented Nov 24, 2016

I have the code added for worldwide zipcode (postcode) lookup via Google, i.e.;
http://maps.googleapis.com/maps/api/geocode/xml?sensor=false&address=G612RW

However it returns the information in XML. I'm just working through the SimpleXML elements that're required to extract the useful info and replace the 'zipcode database' for USA only.

@amaisonneuve
Copy link
Contributor Author

amaisonneuve commented Nov 24, 2016 via email

@RussH
Copy link
Member

RussH commented Nov 24, 2016 via email

@RussH
Copy link
Member

RussH commented Nov 24, 2016 via email

@amaisonneuve
Copy link
Contributor Author

amaisonneuve commented Nov 24, 2016 via email

@RussH
Copy link
Member

RussH commented Nov 25, 2016

Hi Alain, yes we have to select on type and return the associated long_name. The issue appears to be that for different countries, we may want to return different type fields for city & state;
In the UK,
I'd use a type of {(locality) if it exists otherwise (post_town)} for city, and;
use a type of {administrative_area_level_2} for state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants