Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG FIX] Fix install: headers in /path/to/local/include/arpack #398

Merged
merged 4 commits into from
Feb 12, 2023
Merged

[BUG FIX] Fix install: headers in /path/to/local/include/arpack #398

merged 4 commits into from
Feb 12, 2023

Conversation

fghoussen
Copy link
Collaborator

Pull request purpose

fixing issue #394

@fghoussen fghoussen mentioned this pull request Feb 11, 2023
Closed
@fghoussen
Copy link
Collaborator Author

Tests which test installation are broken!

@sylvestre
Copy link
Contributor

headers still get installed in:
debian/tmp/usr/include/arpack-ng/

@fghoussen
Copy link
Collaborator Author

Should be OK

@sylvestre
Copy link
Contributor

Closer ! these files are still installed in arpack-ng

debian/tmp/usr/include/arpack-ng/arpack.h debian/tmp/usr/include/arpack-ng/parpack.h
debian/tmp/usr/include/arpack-ng/arpack.hpp debian/tmp/usr/include/arpack-ng/parpack.hpp
debian/tmp/usr/include/arpack-ng/debug_c.h debian/tmp/usr/include/arpack-ng/stat_c.h
debian/tmp/usr/include/arpack-ng/debug_c.hpp debian/tmp/usr/include/arpack-ng/stat_c.hpp

@fghoussen
Copy link
Collaborator Author

fghoussen commented Feb 12, 2023 •
edited
Loading

I'll have a look. Do you want to suppress the current 3.9.0 tag on master + fix this + retag 3.9.0 on new master, or, create a new tag when this is fixed?

@fghoussen
Copy link
Collaborator Author

Closer ! these files are still installed in arpack-ng

debian/tmp/usr/include/arpack-ng/arpack.h debian/tmp/usr/include/arpack-ng/parpack.h debian/tmp/usr/include/arpack-ng/arpack.hpp debian/tmp/usr/include/arpack-ng/parpack.hpp debian/tmp/usr/include/arpack-ng/debug_c.h debian/tmp/usr/include/arpack-ng/stat_c.h debian/tmp/usr/include/arpack-ng/debug_c.hpp debian/tmp/usr/include/arpack-ng/stat_c.hpp

CI didn't see this because the installation tests do not test C/C++ binding as far as I remember.
Would be good to improve this in the future

@fghoussen fghoussen mentioned this pull request Feb 12, 2023
Closed
@sylvestre
Copy link
Contributor

3.9.0 has been tagged, we should do 3.9.1 now :)

@fghoussen
Copy link
Collaborator Author

@sylvestre: if OK at your side, fix-up and merge

@3rav
Copy link

3rav commented Feb 12, 2023

On the occasion of the 3.9.1 release, I have a bug for 3.9.0 with the -DICBEXMM=ON flag in the mingw32bit (only 32bit) environment:

 [221/222] Building CXX object CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj
  FAILED: CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj 
  D:\M\msys64\mingw32\bin\g++.exe  -IC:/_/B/src/build-MINGW32-static-32 -IC:/_/B/src/arpack-ng-3.9.0 -IC:/_/B/src/arpack-ng-3.9.0/ICB -ID:/M/msys64/mingw32/include/eigen3 -O3 -DNDEBUG -std=gnu++11 -MD -MT CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj -MF CMakeFiles\arpackmm.dir\EXAMPLES\MATRIX_MARKET\arpackmm.cpp.obj.d -o CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj -c C:/_/B/src/arpack-ng-3.9.0/EXAMPLES/MATRIX_MARKET/arpackmm.cpp
  
  
  cc1plus.exe: out of memory allocating 8392703 bytes

@fghoussen
Copy link
Collaborator Author

On the occasion of the 3.9.1 release, I have a bug for 3.9.0 with the -DICBEXMM=ON flag in the mingw32bit (only 32bit) environment:

 [221/222] Building CXX object CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj
  FAILED: CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj 
  D:\M\msys64\mingw32\bin\g++.exe  -IC:/_/B/src/build-MINGW32-static-32 -IC:/_/B/src/arpack-ng-3.9.0 -IC:/_/B/src/arpack-ng-3.9.0/ICB -ID:/M/msys64/mingw32/include/eigen3 -O3 -DNDEBUG -std=gnu++11 -MD -MT CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj -MF CMakeFiles\arpackmm.dir\EXAMPLES\MATRIX_MARKET\arpackmm.cpp.obj.d -o CMakeFiles/arpackmm.dir/EXAMPLES/MATRIX_MARKET/arpackmm.cpp.obj -c C:/_/B/src/arpack-ng-3.9.0/EXAMPLES/MATRIX_MARKET/arpackmm.cpp
  
  
  cc1plus.exe: out of memory allocating 8392703 bytes

Please, avoid mixing different problems: this is not connected to installation problems.
But likely duplicate of #289 : C++ templates are handy but come with big memory requirements (which make build time increase), AFAIK there is nothing to do against this

@fghoussen fghoussen merged commit 459f46a into opencollab:master Feb 12, 2023
@fghoussen fghoussen deleted the fix_install branch February 12, 2023 14:29
@fghoussen fghoussen mentioned this pull request Aug 12, 2023
Merged
turboencabulator added a commit to turboencabulator/arpack-ng that referenced this pull request Aug 13, 2023
@turboencabulator
Move the remaining headers back to ${includedir}/arpack
1eaa94c 
Fixes the files missed by opencollab#398.  ${pkgincludedir} defaults to
${includedir}/@Package@ where @Package@ is "arpack-ng" unless we specify
otherwise, in each Makefile that uses it.

In the pkg-config files, leave ${includedir} unmodified from how
configure defines it.
@turboencabulator turboencabulator mentioned this pull request Aug 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fghoussen @sylvestre @3rav