Fix arpack solver #468
Merged
Fix arpack solver #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghoussen
force-pushed
the
fix_arpack_solver
branch
9 times, most recently
from
d38e380
to
4c42391
Compare
fghoussen
force-pushed
the
fix_arpack_solver
branch
4 times, most recently
from
7f8e456
to
91e49a9
Compare
fghoussen
force-pushed
the
fix_arpack_solver
branch
6 times, most recently
from
33497eb
to
d393bcf
Compare
- Do NOT use eval in bash script which does NOT return command exit code.
- Use a dedicated maxResNorm to test the residual (no point to deduce
it from tol).
fghoussen
force-pushed
the
fix_arpack_solver
branch
from
8cd48b8
to
86ee1d5
Compare
|
@sylvestre: long story short, I had to change the API of the arpack solver and python binding based on it. New (major?) release? |
why ? |
To fix problems related to the way tolerances are used.
C++ et python only. N ot C neither fortran. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request purpose
Fixing limitations of arpack solver: in connection with #465