Skip to content

Commit

Permalink
fix: delete manifest before blobs by default
Browse files Browse the repository at this point in the history
Currently the conformance tests default to deleting manifests after
blobs, which leaves the manifest dangling. Furthermore, the same blob may be
referenced in many manifests.

AFAIK, no client does this.

So changing default behavior.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
  • Loading branch information
rchincha committed Jun 12, 2023
1 parent 58a1fe9 commit 1124f18
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions conformance/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func init() {
runContentDiscoverySetup = true
runContentManagementSetup = true
skipEmptyLayerTest = false
deleteManifestBeforeBlobs = false
deleteManifestBeforeBlobs = true

if os.Getenv(envVarTagName) != "" &&
os.Getenv(envVarManifestDigest) != "" &&
Expand All @@ -323,7 +323,9 @@ func init() {
}

skipEmptyLayerTest, _ = strconv.ParseBool(os.Getenv(envVarPushEmptyLayer))
deleteManifestBeforeBlobs, _ = strconv.ParseBool(os.Getenv(envVarDeleteManifestBeforeBlobs))
if v, ok := os.LookupEnv(envVarDeleteManifestBeforeBlobs); ok {
deleteManifestBeforeBlobs, _ = strconv.ParseBool(v)
}
automaticCrossmountVal := ""
automaticCrossmountVal, runAutomaticCrossmountTest = os.LookupEnv(envVarAutomaticCrossmount)
automaticCrossmountEnabled, _ = strconv.ParseBool(automaticCrossmountVal)
Expand Down

0 comments on commit 1124f18

Please sign in to comment.