Skip to content

Commit

Permalink
Conformance: fix inappropriate test HTTP method (#332)
Browse files Browse the repository at this point in the history
Change HTTP method from PUT to GET to allow a pull only registry to be tested. PUT requests should not be used during pull testing.

Signed-off-by: Graham Miln <graham.miln@miln.eu>
Co-authored-by: Josh Dolitsky <josh@dolit.ski>
  • Loading branch information
grahammiln and jdolitsky committed Jun 21, 2023
1 parent aef0f61 commit 73fe777
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion conformance/01_pull_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ var test01Pull = func() {
g.Context("Error codes", func() {
g.Specify("400 response body should contain OCI-conforming JSON message", func() {
SkipIfDisabled(pull)
req := client.NewRequest(reggie.PUT, "/v2/<name>/manifests/<reference>",
req := client.NewRequest(reggie.GET, "/v2/<name>/manifests/<reference>",
reggie.WithReference("sha256:totallywrong")).
SetHeader("Content-Type", "application/vnd.oci.image.manifest.v1+json").
SetBody(invalidManifestContent)
Expand Down

0 comments on commit 73fe777

Please sign in to comment.