Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Go range to 1.19 - 1.21 #1114

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

sudo-bmitch
Copy link
Contributor

@sudo-bmitch sudo-bmitch commented Sep 3, 2023

This updates the supported Go range to 1.19 - 1.21. The previous supported range was 1.18 - 1.20.

sajayantony
sajayantony previously approved these changes Sep 5, 2023
go.mod Outdated Show resolved Hide resolved
Previous supported range was 1.18 - 1.20.

Signed-off-by: Brandon Mitchell <git@bmitch.net>
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(leaving a blocking review because the more I think about it, the more strongly I feel about the go directive in go.mod)

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't type fast enough 😂

💕

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd personally also be "+1" on adding a GOTOOLCHAIN=local or GOTOOLCHAIN=path in the Makefile (which can be overridden by the user). I'm not a fan of Go's "schödingers version" making its way in my supply chain.

@sudo-bmitch
Copy link
Contributor Author

LGTM

I'd personally also be "+1" on adding a GOTOOLCHAIN=local or GOTOOLCHAIN=path in the Makefile (which can be overridden by the user). I'm not a fan of Go's "schödingers version" making its way in my supply chain.

Great suggestion! I made that a separate PR, #1133.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM 👀

@sajayantony sajayantony merged commit ceeb2eb into opencontainers:main Nov 10, 2023
4 checks passed
@sudo-bmitch sudo-bmitch deleted the pr-go-1.21 branch November 10, 2023 19:22
@sudo-bmitch sudo-bmitch mentioned this pull request Jan 11, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants