-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pin shfmt to v3.2.0 #2671
ci: pin shfmt to v3.2.0 #2671
Conversation
nit: commit title |
We had to use shfmt from git master/HEAD in commit 069fddf as at the time there was no released/tagged version that supports bats syntax. Now there is (https://github.com/mvdan/sh/releases/tag/v3.2.0), so let's pin it to avoid sudden regressions caused by changes in master branch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@mrunalp @AkihiroSuda PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not a huge fan of cd ~ && GO111MODULE=on
stuff, but I can't come up with a better alternative.
Me neither :( this is just a peculiarity of golang, and I hate to do something like |
We had to use shfmt from git master/HEAD in commit 069fddf as at the
time there was no released/tagged version that supports bats syntax.
Now there is (https://github.com/mvdan/sh/releases/tag/v3.2.0),
so let's pin it to avoid sudden regressions caused by changes in master
branch.