Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark runc features experimental; clarify that MountOptions does not contain const void *data options #3310

Merged

Conversation

AkihiroSuda
Copy link
Member

  • Commit 1: Mark runc features experimental
  • Commit 2: types/features: clarify that MountOptions does not contain const void *data options

Follow-up to #3296

Follow-up to PR 3296

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the 1.1.0 milestone Dec 7, 2021
@AkihiroSuda AkihiroSuda force-pushed the mark-runc-features-as-experimental branch from e7f47cc to fdc2dd1 Compare December 7, 2021 09:03
`MountOptions` does not contain `const void *data` options.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the mark-runc-features-as-experimental branch from fdc2dd1 to 97688dd Compare December 7, 2021 09:47
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyphar cyphar closed this in 4b22d8e Dec 8, 2021
@cyphar cyphar merged commit 4b22d8e into opencontainers:master Dec 8, 2021
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants