Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test suite + kind workflow to add them to ci #384

Merged
merged 25 commits into from
Jan 8, 2024
Merged

Integration Test suite + kind workflow to add them to ci #384

merged 25 commits into from
Jan 8, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Oct 6, 2023 •
edited
Loading

The issue resolved by this Pull Request:

Resolves #285

Description of your changes:

Test suite is introduced as its own isolated pagic.

It is platform agnostic, and can be ran against a dev cluster (see readme) or via command line, or kind cluster for pr testing (see attached workflow).

Test suite uses ginkgo/gomega. It uses client-go to verify changes in cluster, and basic rest calls to verify changes to the api server.

There are some basic tests included:

  • verify dspa pod count, and successfully deployment of component pods
  • test pipeline fetch
  • test pipeline upload
  • test experiments list fetch

These tests should give an easy stepping stone for more advanced testing/extensions.

Testing instructions

See readme in the pr

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@HumairAK HumairAK changed the title Kind tests System Test suite + kind workflow to add them to ci Oct 6, 2023
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/384/head
git checkout -b pullrequest bb197177276a8e4209a9643f436407cfd88598ca
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-384"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@HumairAK
Copy link
Contributor Author

Systest nomenclature is incorrect, everything will need to be renamed to integration.

@DharmitD DharmitD mentioned this pull request Oct 19, 2023
Closed
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@HumairAK HumairAK changed the title System Test suite + kind workflow to add them to ci Integration Test suite + kind workflow to add them to ci Oct 19, 2023
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@HumairAK HumairAK force-pushed the kind_tests branch 2 times, most recently from cbb5048 to 468a4b2 Compare October 20, 2023 13:19
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

rimolive
rimolive requested changes Oct 23, 2023
View reviewed changes
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
gmfrasca
gmfrasca reviewed Oct 23, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@HumairAK
Correct linting errors.
efaa455 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add stub main to pass precommit go build check.
2097dbd 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add portforwarding logic and working apiserver url.
5585247 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add pipeline upload test.
e353c07 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Added dspa deploy log messages in sys test.
b62d53d 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Update kind tests to leverage ginkgo system tests.
420a87b 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add systest readme.
63b6be2 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Switch to local build for images.
1e40fbc 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add build flags for systests.
6250eaa 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Remove unused action and add licenses.
ee4ef43 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Rename systest to integartion tests.
3167cb5 
The these tests were incorrectly named, the correct nomenclature as per
dsp testing adr is integration tests.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Add make command for integration tests.
9e15ddc 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@HumairAK
Clean up integration test suite.
2f961f7 
Use constant variables. Remove unused variables in kind tests.
Consistent yaml formatting. Clarify readme.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@openshift-ci openshift-ci bot removed the lgtm label Jan 8, 2024
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

1 similar comment
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@HumairAK
Copy link
Contributor Author

HumairAK commented Jan 8, 2024

/unhold

@HumairAK
Update kind test dspo ns to opendatahub.
efc1399 
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-384

@rimolive
Copy link
Contributor

rimolive commented Jan 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2024
@HumairAK HumairAK merged commit a3ded39 into opendatahub-io:main Jan 8, 2024
5 of 6 checks passed
@jstourac jstourac mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@gmfrasca gmfrasca gmfrasca left review comments

@DharmitD DharmitD DharmitD left review comments

@rimolive rimolive rimolive approved these changes

@amadhusu amadhusu Awaiting requested review from amadhusu

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

Assignees

@rimolive rimolive

@gmfrasca gmfrasca

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a simple test, defined in the Upstream Testing ADR, that leverages upstream testing infrastructure
7 participants
@HumairAK @dsp-developers @rimolive @hbelmiro @gmfrasca @DharmitD @openshift-merge-robot