Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back run and task related permissions #458

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Adding back run and task related permissions #458

merged 1 commit into from
Nov 14, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented Nov 13, 2023

The issue resolved by this Pull Request:

Resolves #354

Description of your changes:

While testing the updates made in #442, we realized that run creation fails and we would need to add permissions related to runs and tasks back in v2 ClusterRoles.

Testing instructions

  • Run the following commands to prepare the environment. NOTE: Make sure there are no other DSP installations in the testing cluster:
$ export IMAGE=quay.io/<QUAY_USERNAME>/dspo:v2
$ export DSPO_NS=data-science-pipelines-operator-v2
$ export DSPA_NS=data-science-pipelines-application-v2
$ oc new-project $DSPO_NS
$ oc new-project $DSPA_NS
$ make podman-build podman-push IMG=$IMAGE
$ make v2deploy IMG=$IMAGE V2INFRA_NS=openshift-pipelines
$ make deploy IMG=$IMAGE OPERATOR_NS=$DSPO_NS

quay.io/rhn_support_ddalvi/data-science-pipelines-operator:latest-clusterroles is the image I built to test these changes. Created a DSPA instance and created a run using the default iris pipeline, the run goes through:

image

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-458
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/458/head
git checkout -b pullrequest eb73db1c2fd317e46e4c9623d5526bf7a5c6ff71
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-458"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit db9d8b1 into opendatahub-io:dspv2 Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants