Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed VisualizationServer and MLMD Writer #512

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Removed VisualizationServer and MLMD Writer #512

merged 6 commits into from
Dec 21, 2023

Conversation

hbelmiro
Copy link
Contributor

The issue resolved by this Pull Request:

Resolves: #495

Description of your changes:

This PR removes the VisualizationServer and MLMD Writer deployments for V2.

Testing instructions

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-512
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/512/head
git checkout -b pullrequest b22deb67dbcb2802f98ddcc34e89c820e761db2f
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-512"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@hbelmiro hbelmiro linked an issue Dec 14, 2023 that may be closed by this pull request
Remove visualization server and mlmd writer from v2 poc #495
Closed
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-512

@hbelmiro
Removed VisualizationServer and MLMD Writer
dd54ed5
@hbelmiro
Restored ML_PIPELINE_VISUALIZATIONSERVER_SERVICE_HOST and ML_PIPELINE…
4ff63f6 
…_VISUALIZATIONSERVER_SERVICE_PORT envs

Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro
Removed GetImageForComponentV2
c9da18a 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@hbelmiro
Restored SetupMLMD
af2e5a8 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-512

@hbelmiro @gmfrasca
Updated DSPAParams#UsingV1Pipelines.
8e65d60 
Co-authored-by: Giulio Frasca <giulio.m.frasca@gmail.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-512

rimolive
rimolive requested changes Dec 20, 2023
View reviewed changes
config/samples/dspa_simple_v2.yaml Outdated Show resolved Hide resolved
controllers/dspipeline_params.go Show resolved Hide resolved
@hbelmiro
Restored health check
a311b92 
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-512

@openshift-ci openshift-ci bot added the lgtm label Dec 21, 2023
rimolive
rimolive reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@rimolive rimolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmfrasca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 54ddfde into opendatahub-io:dspv2 Dec 21, 2023
5 checks passed
@hbelmiro hbelmiro deleted the issue-495 branch December 22, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive rimolive requested changes

@gmfrasca gmfrasca gmfrasca approved these changes

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

@HumairAK HumairAK Awaiting requested review from HumairAK

Assignees

@rimolive rimolive

@gmfrasca gmfrasca

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove visualization server and mlmd writer from v2 poc
5 participants
@hbelmiro @dsp-developers @rimolive @gmfrasca @openshift-merge-robot